[Controller] Replace selector only when function is ready #3235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomerShor
reviewed
Apr 28, 2024
There was a problem hiding this comment.
With the current implementation it seems that the function resources will be created and updated twice in a row - once for the FunctionStateWaitingForScaleResourcesFromZero state, and once for the FunctionStateWaitingForReadinessWhenScaleFromZero.
I understand that you want to update the service labels, but it is a part of the entire resource creation flow, so you will basically have to wait for all resources to be ready again...
|
@TomerShor that is true. Another option here is to update service right after waiting for available. However, it will ruin our consistency in terms of updating resources and waiting for availability in one place. |
TomerShor
requested changes
May 2, 2024
TomerShor
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where on all request except the 1st one to scaledToZero function we returned 503 error without waiting for the function start.
Jira - https://iguazio.atlassian.net/browse/NUC-1 (solution is explained in the task)