-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Batcher] Add ability to send batched http requests to runtime #3244
Conversation
# Conflicts: # pkg/functionconfig/types.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial comments.
Will batching be supported in all triggers right OOB?
Since we only support it on python runtime for now, I would add a warning log that it is not supported if a different runtime is set (and maybe for triggers that don't support it too (e.g. shell))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good!
A couple of minor suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome stuff!
Added a few comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit more to go :)
} | ||
|
||
// use the event @ the worker index | ||
// TODO: event already used? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it is not you TODO, but do you have an idea what does it mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TomerShor No, but I can assume that it is only relevant for normal flow with single event processing, because in that case we use pre-defined events to wrap the context
Jira - https://iguazio.atlassian.net/browse/NUC-156 part of https://iguazio.atlassian.net/browse/NUC-146
This PR introduces a new events processing logic. Specifically, it allows the processing of batched events instead of the usual single event processing. For now, we only support this feature for python runtime and http trigger kind.
Batching can be enabled by adding
batch
configuration to function config.Example: