Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 'ConvertInterfaceLuidToIndex' to obtain the index #26

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Use 'ConvertInterfaceLuidToIndex' to obtain the index #26

wants to merge 3 commits into from

Conversation

vnt-dev
Copy link

@vnt-dev vnt-dev commented Aug 20, 2024

No description provided.

@xmh0511 xmh0511 mentioned this pull request Aug 20, 2024
Open
TroyNeubauer
TroyNeubauer approved these changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@TroyNeubauer TroyNeubauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, but approach looks good!

src/adapter.rs Outdated Show resolved Hide resolved
src/adapter.rs Show resolved Hide resolved
src/ffi.rs Show resolved Hide resolved
@TroyNeubauer
Copy link
Collaborator

Looks good, thanks!
Do you mind fixing the clippy error? Looks like the rules around comment indenting changed in a recent version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TroyNeubauer TroyNeubauer TroyNeubauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vnt-dev @TroyNeubauer