Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vicky Thomas Project #19

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

vickyat
Copy link

@vickyat vickyat commented Dec 16, 2015

No description provided.

@labarba
Copy link
Member

labarba commented Jan 4, 2016

In the introductory paragraphs, you say that your application of interest is a conveyor belt. But you didn’t try to illustrate the application, as you just write down an equation and simply tell your reader that it describes “the movement of a string-like belt.” You did not explain what the dependent variable u represents.

"An example of a mixed PDE looks like” —> what you show is simply a mixed partial derivative operator … not a PDE (there is no equation shown!)

“Any kind of discretization can be used …” —> This appears to contradict what we stressed throughout this course, which is that the selection of an appropriate discretization scheme needs to take into account the physics represented by the PDE.

Then you show the discretization of the second-order time and space derivatives, and call that “Euler’s method.” That is not Euler’s method.
What you show next for the time derivative, du/dt, that is Euler’s method (it is the same as “forward in time”).

Also, we covered second-order derivatives in the course. We saw them for the first time in Module 2, with the diffusion equation (notebook 3)
http://nbviewer.ipython.org/github/numerical-mooc/numerical-mooc/blob/master/lessons/02_spacetime/02_03_1DDiffusion.ipynb

The discrete second-order derivative is shown there in Eq. (2).
This is not what you are showing for your discretizations of similar terms.
I’m afraid what you have is wrong :-(

BCs: “We need two since our time variable is second order” —> time derivative is second order

The rest of the notebook applies what we learned in the course about how to set up the solution with implicit methods (Module 4, notebook 2). The procedure looks correct, but of course you carry the mistake from the bad discretization.

In your second reference (from Physics Forums), the discussion thread finally arrives at an analytical solution for the PDE, which your could have used to check that your numerical solution is correct. You might have found your mistake then …

But in the end, you got “a solution” to your numerical problem, and it looks like you accepted it without reflecting on what it means, or what the physics of the problem should look like. Overall, it’s a cursory investigation of the problem, and it seems rushed (hence the mistakes).

Typos, grammar, etc.

so that its very clear —> it's

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants