Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Randy Schur Project Submission #8

Open
wants to merge 63 commits into
base: master
Choose a base branch
from
Open

Conversation

rbds
Copy link

@rbds rbds commented Dec 15, 2015

No description provided.

@ncclementi
Copy link
Member

Randy, you have two different notebooks, which one are we supposed to read? If both in which order? You need to tell us, because the original idea was having 1 notebook. Please give us some guidance so we can read you project and give you some feedback.

@rbds
Copy link
Author

rbds commented Dec 21, 2015

The notebook was getting too long, so I split it in two parts. The first is
called Integration techniques for mechanical systems, and the second is
called double pendulum problem.

On Mon, Dec 21, 2015 at 5:27 PM ncclementi notifications@github.com wrote:

Randy, you have two different notebooks, which one are we supposed to
read? If both in which order? You need to tell us, because the original
idea was having 1 notebook. Please give us some guidance so we can read you
project and give you some feedback.


Reply to this email directly or view it on GitHub
#8 (comment)
.

@ncclementi
Copy link
Member

On Integration of Mechanical Systems

  • In RK4 you say, for more details see (cite). Can you specify which all of the citations is the one that correspond to this part.
  • In the function RK2 the docstring says "Runge Kutta fourth order integration method" it should be second order.
  • When you plot the legend on the plots, you can choose where to put it so it doesn't disturb the plot. Check this link http://stackoverflow.com/questions/4700614/how-to-put-the-legend-out-of-the-plot
  • In the screen shots you are presenting (32 bit vs 64 bit) I think it will help if you put in the title of each figure which one is 32 and which one is 64.
  • In the L1-norm plot,we need a legend, it makes easy to read the plot, otherwise we have to go to the previous one and compare the colours.

*In the energy in damped HO plot and the phase portrait, RK2 and RK4 don't appear, why? Are they overlapped?

  • You should have a conclusion title or something to finish up the lesson, or a connection with the second notebook.

typos:

energy, Conservation ---> energy. Conservation (or conservation in lower case)
here, the we can -------> here, we can

On Double pendulum : no comments.

Really interesting work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants