Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final Project - Ye Qin #9

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

yeqin1992
Copy link

The final project for MAE 6286

@ncclementi
Copy link
Member

  • Why did you use the Patankar scheme for the non linear term? it would help some introduction/ explanation.
  • In the discretization part, the last equation is wrong it has a typo. However, in the code is write.
  • How you get that the stability criterion is \Delta_t /\Delta_x^2 <0.5.? Can you explain it ?
  • The initial condition, after the title Compute, you need to write it better, it is all in one line and it's confusing.
  • You say "However, we will talk about this in the next lesson." which one is the "next lesson" that you are talking about?

*Overall, I think your discussion is poor. Your work followed almost exactly your reference number 2, leaving your contribution to just the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants