Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final Project_Xiaofan Liu #17

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Xiaofan91
Copy link

My final project

My final project
My final project. A little correction from the previous one.
My final project
@labarba
Copy link
Member

labarba commented Jan 2, 2015

Nice job. One thing that you should definitely take more care with is that you are using images from an un-cited source. It looks like they are figures from a textbook. You must add an image credit to these, with a note to their copyright! You might even add a note about their inclusion under fair use, because this is an educational work. (In general, though, one cannot reuse copyrighted images without permission of the rights holder!)

Notice that you are loading the NumPy library twice! Pick a way to load it, and stick with it. We prefer import numpy, simply, and all its methods need to be used as numpy.method().

Mechanics of vibrations is not fresh in my memory, so I followed your derivations like your regular reader. In doing so, I was confused at times. The expression x r=gamma theta, for example, does not make sense to me. Something seems off there. If the angle theta is small, then the arc A–A' would be given by r times theta. (By the way, you forgot to define r when you first use it—it only appears on the second figure, but not defined in the text.) And when looking at a thin cross-sectional slice of the shaft, the shear strain would be given by shear angle (gamma) times dx. Maybe you got some variables turned around here?

About the stability constraint: where did you get that the CFL condition for this equation discretized with central differences was �sigma<0.5. And then why would you choose a time step that is 10 times smaller than your stability limit?! In fact, the wave equation is subject to the typical CFL condition of sigma<1 for explicit methods.
Also, in this paragraph you associate stability to keeping your plot looking nice. Saying this lacks in depth: the property of stability belongs to the numerical solution (and we discussed this amply in class!) and it's not just about getting a nice plot.

To get your numerical solution started, you used the Taylor series of theta, the known initial value of the angular velocity, and a finite-difference approximation of the second derivative. You missed the opportunity of making a statement here about the order of accuracy of this starting scheme. It's an important detail because in many starting schemes one gets stuck with a lower-order accuracy than the overall solution. Is that the case here?

Now, your solution with the explicit method looks strange ... and, as you can see, the solution is different than the one you get with the implicit method. Something is wrong ... I suspect you have a bug.
Pinging @gforsyth here to see if can help us spot the bug.

Finally, the title could be more informative about the topic of the notebook if it said that it refers to torsional vibrations. Maybe just "Torsional vibrations of a shaft" would do.
And your references should include the textbook where you got those images from!

A couple of LaTeX typos:
... tau(x,t) —>missing backslash
... frac : fourth equation down section titled "Discretizing ..." —>missing backslash
... fifth equation, same section —> superscript {n-1} missing ^

Typos and Style:
"the equation we are gonna use" —>please use standard English: "going to use"
"never wanna forget"—>want to

Based on these information—>this information
Not rember—>Don't remember
konwns—>known parameters

"with what have gotten."—> with what we have?
Mr.Taylor show—>Mr.Taylor shows
Based on these—>Based on this
Rember—>Remember (and again below)
solve this problem in implicit schemes—> with implicit schemes
appear in three sequent equations—>appears in three consecutive equations
sovle the equation—>solve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants