Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use black #391

Merged
merged 2 commits into from
May 10, 2022
Merged

Use black #391

merged 2 commits into from
May 10, 2022

Conversation

jarrodmillman
Copy link
Member

I am leaving this draft until it is approved to prevent it from being merged. If it is approved, I will merge it (but not squash it, so I will need to enable that option before merging). The reason I will do that is so I can keep all the black formatting stuff in one commit that I will add to a .git-blame-ignore-revs file.

@jarrodmillman jarrodmillman marked this pull request as draft May 8, 2022 02:53
@jarrodmillman jarrodmillman changed the title Black Use black May 8, 2022
@larsoner
Copy link
Collaborator

larsoner commented May 9, 2022

I have not kept up to speed on what NumPy has done, but +1 for merge assuming this follows whatever they do, whenever they do it :)

Copy link
Collaborator

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve but it would be nice if another maintainer (@rgommers ? @jnothman ?) could weigh in as well!

@jarrodmillman jarrodmillman added this to the 1.4.0 milestone May 10, 2022
Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm +1 on adding an autoformatter as well. Given the discussion on the numpy mailing list, black seems like the sensible choice. Some of the other concerns for numpy e.g. the formatting for math and large arrays are not really a concern for numpydoc.

@larsoner
Copy link
Collaborator

Okay sounds like you have the green light to proceed @jarrodmillman !

@jarrodmillman jarrodmillman marked this pull request as ready for review May 10, 2022 21:41
@jarrodmillman jarrodmillman merged commit 171e353 into numpy:main May 10, 2022
@jarrodmillman jarrodmillman deleted the black branch September 28, 2022 04:12
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants