-
-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use black #391
Use black #391
Conversation
I have not kept up to speed on what NumPy has done, but +1 for merge assuming this follows whatever they do, whenever they do it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm +1 on adding an autoformatter as well. Given the discussion on the numpy mailing list, black seems like the sensible choice. Some of the other concerns for numpy e.g. the formatting for math and large arrays are not really a concern for numpydoc.
Okay sounds like you have the green light to proceed @jarrodmillman ! |
I am leaving this draft until it is approved to prevent it from being merged. If it is approved, I will merge it (but not squash it, so I will need to enable that option before merging). The reason I will do that is so I can keep all the black formatting stuff in one commit that I will add to a
.git-blame-ignore-revs
file.