Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #385, we tentatively agreed to drop support for sphinx 3 with numpy 1.4. We are releasing 1.4 a little sooner than planned.
However, the 1.4 release mainly adds support for new versions of docutils. So for folks using sphinx 3, then there is no reason for them to use numpydoc 1.4. Moreover, pydata-sphinx-theme and myst-parser have dropped support for sphinx 3 with their recent releases. Finally, in #393, you can see that numpydoc doesn't support sphinx ~= 3.5 under python 3.10 and above. You can also see in 6108474 that we require sphinx >= 4.2 under python 3.10 and above (see sphinx-doc/sphinx#9562 for more information).
Maybe it is too aggressive, but I think it may make sense to require sphinx >= 4.2.
If we only require
sphinx>=4.0.2
, how should we document that for Python 3.10+ we requiresphinx>=4.2
?Thoughts?