Recognize .NET 7 when installed #1197
Conversation
| @@ -201,6 +201,8 @@ private Version GetClrVersionForFramework(Version frameworkVersion) | |||
| return new Version(5, 0, 1); | |||
| case 6: | |||
| return new Version(6, 0, 0); | |||
| case 7: | |||
| return new Version(7, 0, 0); | |||
There was a problem hiding this comment.
@CharliePoole : Sorry I'm getting to this so late, I followed this here based on the comments here. I was curious if this would be a problem once .NET 8 (and future versions of .NET) get released...
/cc: @OsirisTerje
There was a problem hiding this comment.
Yes, it would, at least for anyone continuing to use 3.15.2 at that point. However, subsequent changes, to be released in 3.16, eliminated throwing of an exception when the runtime is not recognized. In addition, version 4.0 code eliminates this call entirely, dropping the need for the CLR version entirely. Both of the above are superior, in my opinion, to the often suggested option of using <MajorVersion>.0.0 because that involves predicting Microsoft's future actions.
There was a problem hiding this comment.
That makes a lot of sense. Glad the newer versions have this fixed up.
There was a problem hiding this comment.
@CharliePoole I'm hitting this again with .NET 8 preview installed. How do I get VS/dotnet test to use 3.16?
There was a problem hiding this comment.
That's based on the version of the NUnit VS adapter you are using. Check with @OsirisTerje on that project.
There was a problem hiding this comment.
@madelson We need a new version of the engine, 3.16.3. It should be released any day now, and then version 4.4.0 of the adapter will have this embedded. It will be released immediately after the 3.16.3
|
@AbhitejJohn Version 3.16.3 of the engine/console is out now, and it accepts all higher versions, and the adapter 4.4.0 is out (beta.1 now, but the non-beta will be released this weekend,) with the 3.16.3 engine, so there will be no further issues with that one either. See https://docs.nunit.org/articles/vs-test-adapter/AdapterV4-Release-Notes.html |
Re-merging the fix for #1193 into the new version3 branch