New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #1183 to version315: Eliminate hang due to TcpListener thread #1373

Merged

OsirisTerje merged 2 commits into nunit:version315 from ValentijnMakkenze:issue-1371-2

Dec 24, 2023

Contributor

ValentijnMakkenze commented Dec 20, 2023

Fixes #1183 in version315 branch

CharliePoole and others added 2 commits

December 20, 2023 09:03


          Fix hang when test processes fail to terminate correctly

229f922


          Also copy changes from version3 branch

aa4714d

ValentijnMakkenze mentioned this pull request

Stuck between versions #1371

Closed

Member

OsirisTerje commented Dec 24, 2023 •

edited

Loading

This PR adds a test and does a rename?
Not sure I understand how this eliminates hangs.

UPDATE: Ok, I probably see it, lines 37-41 in the server file. The renames confused me.

OsirisTerje merged commit c52aa3d into nunit:version315

2 checks passed

ValentijnMakkenze deleted the issue-1371-2 branch

December 27, 2023 07:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet