Skip to content

Commit

Permalink
build: Fix an incorrect make variable passed to goreleaser (#716)
Browse files Browse the repository at this point in the history
**What problem does this PR solve?**:
The make variable reference was replaced recently in
https://github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/pull/704/files#diff-fa98b7f1d4a049ad777fb9453f6657c512c8b715a9f8bc47dfd57f1143bbb930L14.

The new reference is to `GORELEASE_VERBOSE`, which is unset, and
goreleaser fails:

```shell
> make build-snapshot
▶ running go generate
make[1]: Entering directory '/home/dlipovetsky/nutanix/capi-runtime-extensions'
▶ configuring supported csi providers
make[1]: Leaving directory '/home/dlipovetsky/nutanix/capi-runtime-extensions'
▶ building snapshot
  ⨯ command failed                                   error=invalid argument "" for "--verbose" flag: strconv.ParseBool: parsing "": invalid syntax
```

Not sure how CI passed for #704, because this issue affects main.

**Which issue(s) this PR fixes**:
Fixes #

**How Has This Been Tested?**:
<!--
Please describe the tests that you ran to verify your changes.
Provide output from the tests and any manual steps needed to replicate
the tests.
-->

**Special notes for your reviewer**:
<!--
Use this to provide any additional information to the reviewers.
This may include:
- Best way to review the PR.
- Where the author wants the most review attention on.
- etc.
-->
  • Loading branch information
dlipovetsky committed Jun 12, 2024
1 parent 6a23695 commit 76c7c6f
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions make/goreleaser.mk
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# SPDX-License-Identifier: Apache-2.0

GORELEASER_PARALLELISM ?= $(shell nproc --ignore=1)
GORELEASER_DEBUG ?= false
GORELEASER_VERBOSE ?= false

ifndef GORELEASER_CURRENT_TAG
export GORELEASER_CURRENT_TAG=$(GIT_TAG)
Expand All @@ -21,7 +21,7 @@ build-snapshot: go-generate ; $(info $(M) building snapshot $*)
.PHONY: release
release: ## Builds a release with goreleaser
release: go-generate ; $(info $(M) building release $*)
goreleaser --verbose=$(GORELEASER_DEBUG) \
goreleaser --verbose=$(GORELEASER_VERBOSE) \
release \
--clean \
--parallelism=$(GORELEASER_PARALLELISM) \
Expand All @@ -31,7 +31,7 @@ release: go-generate ; $(info $(M) building release $*)
.PHONY: release-snapshot
release-snapshot: ## Builds a snapshot release with goreleaser
release-snapshot: go-generate ; $(info $(M) building snapshot release $*)
goreleaser --verbose=$(GORELEASER_DEBUG) \
goreleaser --verbose=$(GORELEASER_VERBOSE) \
release \
--snapshot \
--clean \
Expand Down

0 comments on commit 76c7c6f

Please sign in to comment.