test(e2e): Find specific CRS binding when checking if resource is applied #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmidyson
force-pushed
the
jimmi/e2e-crs-helper-refactor
branch
from
b530f82
to
b687577
Compare
jimmidyson
changed the title
dkoshkin
reviewed
Feb 23, 2024
There was a problem hiding this comment.
Great find! Lets wait for the upstream to merge and sync up again https://github.com/kubernetes-sigs/cluster-api/pull/10191/files
Check the relevant ResourceSetBinding to see if the resource is applied. If multiple ClusterResourceSets match a cluster, the ClusterResourceSetBinding will have multiple bindings and so only the relevant ResourceSetBinding should be checked.
jimmidyson
force-pushed
the
jimmi/e2e-crs-helper-refactor
branch
from
b687577
to
01cc1b5
Compare
dkoshkin
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream PR kubernetes-sigs/cluster-api#10191