chore(bridge): Improve typing for vueApp #1996
Conversation
|
✔️ Deploy Preview for nuxt3-docs canceled. 🔨 Explore the source changes: 52dfb21 🔍 Inspect the deploy log: https://app.netlify.com/sites/nuxt3-docs/deploys/6195195d2b13960008504a05 |
| export interface NuxtAppCompat { | ||
| nuxt2Context: Vue | ||
| vue2App: ComponentOptions<Vue> | ||
|
|
||
| vueApp: VueAppCompat | ||
| vueApp: VueConstructor |
There was a problem hiding this comment.
vueApp is a vue@3 a partial shim (while VueConstructor imported from vue in Nuxt2/bridge is from Vue2). Maybe we can use VueConstructor and keep VueAppCompat?
There was a problem hiding this comment.
Can you maybe clarify the purpose of vueApp in the context of bridge. All plugins and other libraries are based on vue2 anyway. Or is it meant as a migration path to use vue3-based libraries with nuxt/bridge?
There was a problem hiding this comment.
Indeed. it mimic vue3 insterface for integrations with vue3-only libs like @vueuse/head. Otherwise on bridge you should rely on nuxtApp.vue2App if plugin is meant to be used for Vue2
There was a problem hiding this comment.
Okay thanks for the clarification. In this case, this PR doesn't make any sense. Let me see if I find a nice solution for VueAppCompat and I'll open a new PR then.
🔗 Linked issue
❓ Type of change
📚 Description
The methods of
nuxtApp.vueAppwere of typeanyfor me. Instead of using theVueAppCompatinterface, I propose to directly useVueConstructor.📝 Checklist