-
-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Impossible to build NVDA after introduction of UIA remote library #13346
Comments
cc @michaelDCurran We should either understand why build does not work on Windows 7 and fix the cause, or at the very least clearly document what are system requirements for NVDA development if this cannot be fixed. |
I assume you have the Windows 11 SDK installed? I don't understand why the midl compiler would actually fail on a particular version of Windows. |
Ugh, for me they actually also fail on Visual Studio 2022 because I don't have the VS2019 build tools installed. clearly the project has them hardcoded. Mus say that the way we're building this is quite nasty. |
Yes, I do have Windows 11 SDK installed. I've opened microsoft/Microsoft-UI-UIAutomation#89 to establish what is the cause or get a clarification as to what versions of Windows are supported when building. |
Use of the UIA remote ops library has been reverted until we can solve these build issues. |
I can confirm that NVDA Master builds again on my machine. |
Closed by ac06b96 |
…Word via UIA, using UIA remote ops (#13387) This reintroduces the commits in pr #13283 which had been reverted in pr #13350. However it also addresses build issues. Summary of the issue: PR #13283 introduced support for reporting line/column/section numbers in Microsoft word via UI Automation, by using the UI Automation Remote Operations Library. However, this PR had to be reverted in #13350 as 1. UIA would not initialize properly in binary builds due to a missing manifest file. (Improper initialization of UIA during NVDA start #13347) 2. NVDA failed to build on Visual Studio 2022. Specifically when building the Remote Ops library with msbuild, midl would fail with an error about a system environment variable being missing. 3. NVDA could no longer be built on Windows 7. (Impossible to build NVDA after introduction of UIA remote library #13346) Description of how this pull request fixes the issue: This PR reintroduces all of the original changes, but: • setup.py now includes *.manifest files in the lib directory. • NVDA again now requires Visual Studio 2019. However, builds will not fail if a newer version of Visual Studio (E.g. 2022) is installed along side 2019. this is managed by setting MSVC_VERSION in scons before it looks for Visual Studio, so that it specifically selects VS 2019 (VC 14.2). Although building on Windows 7 could not be fixed, the readme now notes that only building on Windows 10 and higher is supported.
Steps to reproduce:
Check out NVDA repository and execute
scons source
Actual behavior:
Build fails with the following:
Expected behavior:
Build succeeds
System configuration
NVDA installed/portable/running from source:
From sources
NVDA version:
Latest master after introduction of PR #13283
Windows version:
Windows 7 X64
Name and version of other software in use when reproducing the issue:
Visual Studio 2019
Other information about your system:
With the same version of Visual Studio build works on Windows 11
Other questions
Does the issue still occur after restarting your computer?
Yes, it does
Have you tried any other versions of NVDA? If so, please report their behaviors.
Build worked until merge of #13283
If NVDA add-ons are disabled, is your problem still occurring?
N/A
Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?
N/A
The text was updated successfully, but these errors were encountered: