Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NVDA no longer works on machines without sound card, such as AppVeyor CI runner #16269

Closed
lukaszgo1 opened this issue Mar 6, 2024 · 1 comment · Fixed by #16270
Closed

NVDA no longer works on machines without sound card, such as AppVeyor CI runner #16269

lukaszgo1 opened this issue Mar 6, 2024 · 1 comment · Fixed by #16270
Milestone

Comments

@lukaszgo1
Copy link
Contributor

Steps to reproduce:

Try starting NVDA on a VM in AppVeyor CI.

Actual behavior:

NVDA fails to star with the following in the log:

CRITICAL - __main__ (06:22:13.355) - MainThread (7092):
core failure
Traceback (most recent call last):
  File "nvda.pyw", line 415, in <module>
  File "core.pyc", line 684, in main
  File "audio\soundSplit.pyc", line 81, in initialize
  File "pycaw\utils.pyc", line 197, in GetAudioSessionManager
  File "pycaw\utils.pyc", line 177, in GetSpeakers
_ctypes.COMError: (-2147023728, 'Element not found.', (None, None, None, 0, None))

Expected behavior:

NVDA should start

NVDA logs, crash dumps and other attachments:

System configuration

NVDA installed/portable/running from source:

N/A

NVDA version:

All after merge of PR #16071

Windows version:

N/A

Name and version of other software in use when reproducing the issue:

None

Other information about your system:

Other questions

Does the issue still occur after restarting your computer?

Yes

Have you tried any other versions of NVDA? If so, please report their behaviors.

Versions before #16071 don't have this problem

If NVDA add-ons are disabled, is your problem still occurring?

Yes

Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?

N/A

Additional context:

This currently prevents new Alpha builds from being created.
cc @mltony as this is caused by your PR.
Also @seanbudd for awareness as it looks like @mltony 's work was merged despite failing CI. Our release process explicitly mentions that only PR's where CI was successful can be merged, and it would be good to follow this standard practice. The fact that our system tests used to fail intermittently should cause them to be improved, rather than failures to be ignored.

@josephsl
Copy link
Collaborator

josephsl commented Mar 6, 2024 via email

seanbudd pushed a commit that referenced this issue Mar 6, 2024
Closes #16269
Fixup of #16071

Summary of the issue:
Exception _ctypes.COMError is thrown at startup on AppVeyor CI runner because hno sound device is present.

Description of user facing changes
N/A

Description of development approach
Catching and logging exception. Returning from soundSplit.initialize function so that initialization can continue.

Testing strategy:
Not sure how to test on AppVeyor, but judging by the exception providded - this should fix the error.
Tested on my local computer to avoid syntax errors.
@nvaccessAuto nvaccessAuto added this to the 2024.2 milestone Mar 6, 2024
Adriani90 pushed a commit to Adriani90/nvda that referenced this issue Mar 13, 2024
…ess#16270)

Closes nvaccess#16269
Fixup of nvaccess#16071

Summary of the issue:
Exception _ctypes.COMError is thrown at startup on AppVeyor CI runner because hno sound device is present.

Description of user facing changes
N/A

Description of development approach
Catching and logging exception. Returning from soundSplit.initialize function so that initialization can continue.

Testing strategy:
Not sure how to test on AppVeyor, but judging by the exception providded - this should fix the error.
Tested on my local computer to avoid syntax errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants