-
-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support UI Automation custom annotations such as notes in MS Excel #12861
Conversation
…ows.ui.uiAutomation.core.CoreAutomationRegistrar. Only available on Windows 11 and above.
Only available on Windows 11 and above.
Only available on Windows 11 and above.
Nice to see! Guessing custom patterns are on the roadmap as well (and perhaps better leveraging remote ops)? |
See test results for failed build of commit f3a31caf02 |
This cannot yet build on Appveyor as the Windows SDK is not new enough. |
Improve docstring. Co-authored-by: Reef Turner <feerrenrut@users.noreply.github.com>
See test results for failed build of commit c72e5e740f |
See test results for failed build of commit 8e181946b5 |
See test results for failed build of commit 8f398739cf |
Looks like the needed files are in Windows SDK 10.0.22000, but not in 10.0.20348, which seems to be the latest public release that comes with VS 2019. |
I've triggered a rebuild for this now that the SDK has been updated on appveyor |
@michaelDCurran Don't forget to update the readme to mention that the never version of SDK is now required. |
@michaelDCurran could you please update the changes for developers section that the Windows 11 SDK is now required? I think this one's easy to miss. |
… annotations. Report existance of draft and resolved comments in MS Word with UIA enabled.
Add a report bookmarks setting to Document formatting category.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
If there are more features to add, please make a new PR with this as base.
This pr now covers all the existing MS Office custom UIA annotation types.
|
… in elements list
Link to issue number:
None.
Summary of the issue:
The Microsoft UI Automation accessibility API has a concept of annotations, which are essentially a way of attaching extra meta information (or annotations) to content. E.g. comments. An annotation is made up of both a known type ID E.g. AnnotationType_Comment, and an object (an extra UI automation element containing properties such as the author, date etc). NVDA already supports standard UI Automation annotations.
In Windows 11, UI Automation has been extended to support custom annotations. these are annotations with an application-defined type ID. E.g. an Excel note, or an MS word bookmark.
In order for these type IDs to be agreed upon by both the application and assistive technology at runtime, a mechanism very similar to UI Automation custom property registration was introduced to UI automation for registering custom annotation types, exposed via the Windows.UI.UIAutomation.Core.CoreAutomationRegistrar winRT interface.
Description of how this pull request fixes the issue:
Testing strategy:
On a Windows 11 machine with MS Excel build 16.0.14509.20000:
Known issues with pull request:
None known.
Change log entries:
New features
Changes for Developers
Code Review Checklist: