Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update outdated description of the synthesizer controls in NVDA's speech settings #17186

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

SaschaCowley
Copy link
Member

Link to issue number:

None

Summary of the issue:

Section 12.1.2.2, "Change synthesizer" of NVDA's User Guide currently reads:

[...] This button activates the Select Synthesizer dialog, which allows you to select the active speech synthesizer and output device. [...]

Even though output device selection has been moved to NVDA's audio settings.

Description of user facing changes

The outdated reference to changing the audio output device via the speech synthesizer dialog has been removed.

Description of development approach

Removed the words "and output device" from the description of the synthesizer section of the speech page of NVDA's settings in user_docs/en/userGuide.md.

Testing strategy:

Built the user guide and made sure the words were gone and the formatting was still correct.

Known issues with pull request:

None.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

Copy link
Member

@Qchristensen Qchristensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good little pickup, nice.

@seanbudd seanbudd merged commit 4dbda63 into master Sep 19, 2024
4 checks passed
@seanbudd seanbudd deleted the fixChangeSynthDocs branch September 19, 2024 01:10
@github-actions github-actions bot added this to the 2025.1 milestone Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants