… shows a message. re nvaccess#3208.

First of a series of foundations for add-on update facility: add a 'Check for Add-on Update' (shortcut: U) that'll let users update installed add-ons. For now, the button is non-functional - shows a message box until the client is working.

…ns manager progress dialog changes. re nvaccess#3208.

Add-on handler: add a new function (checkForAddonUpdates) that'll allow NvDA to check for add-on updates. This is to be used from add-ons manager (manual) or when NVDA starts (automatic). The goal of this function is to gather add-on listings, connect online to retrieve add-on update information, and return this info in a format that a new add-on update result dialog will use to display and download add-on bundles. The add-on update check should not run if NVDA itself is being updated (NvDA Core takes precedence).
In add-ons manager, the progress bar dialog used for add-on installation is now an attribute of the dialog itself, as it is now used for update status message as well. Also, update check button briefly displays progress dialog and returns to add-ons manager. Eventually a new add-on update result dialog will be added that'll display add-on update info returned by addonHandler.checkForAddonUpdates and download new bundles.

…on check emulation in addonHandler.checkForAddonUpdates function. re nvaccess#3208.

A prototype of add-on update check results dialog has been implemented:
* When 'update add-ons' button is pressed, a background thread will call addonHandler.checkForAddonUpdates. This function will emulate a typical add-on update check routine by sleeping for three seconds, then populating the results dictionary with records of installed add-ons, with add-on names (identifiers) as keys and containing summary and version information.
* Once update info is retrieved, the update progress bar stops, and a results dialog will be shown. While checking for updates, Add-ons Manager window will be hidden until a suitable way of showing add-on update check progress and results with Add-ons Manager window disabled is found.
* The AddonUpdatesDialog (the results dialog class) borrows heavily from NVDA Core update results dialog, displaying a list of add-ons with updates (at least emulated) or a message if update info is filled in or not, respectively.
* For now, when 'update' button is pressed from results dialog, it'll do nothing. Eventually the update button will use a refactored file downloader to download and install updates, using the file path and hash that'll be supplied by the update info dictionary.

…. re nvaccess#3208.

Similar to add-on instalaltion routines but with a difference: no prompts will be shown when updating add-ons unless serious errors occur. The new updateAddons function takes a map of new add-ons to be installed, which is a map with add-on identifiers (names) as keys and info such as path as subkeys. This function will be called when user tells NVDA to update add-ons from update results dialog.

… involves sending and receiving data in JSON format. re nvaccess#3208.

Javascript Object Notation (JSON) is a handy way to serialize and deserialize data across various systems, including sending data over a network. It can be used to send an receive various data, such as nested dictionaries, lists and so on.
In case of add-on update checker, JSON wil be employed to store add-on update information from a local NVDA installation, as well as to parse what the update server says about a possible update. A blueprint (pseudo-code) has been provided to spell out what the add-on update checker should do to accomplish its task.

…e currently installed version. re nvaccess#3208.

…s will be fetched from info url value. re nvaccess#3208.

An add-on downloader, based on updateCheck's downloader has been implemented. The only differences are title and content of the progress dialogs, destination path name and extension, and what happens once download completes (installs add-ons).
In terms of update URL's, the same approach as in NVDA Core: url list will be stored in the update info dictionary.
The only showstopper is the problem where progress dialogs for add-on downloads won't go away if multiple add-ons are being downloaded and if at least one of them has an installation UI. Once this is fixed, the manual add-on update check is considered complete (the remaining item for the client is automatic update checks, and the rest will be server's job).

…oblem, update results diallg will now handle the case of no add-on updates. re nvaccess#3208.

Somehow, either because of lack of proficiency in GUI programming (from me) or what not, when add-on update results are displayed, add-ons manager is not focused once that window is closed. This is more so after multiple add-ons are updated at the same time.
Also, update results dialog will present a message (not a list of add-ons) when no add-on updates are available, as well as laying the foundation for automatic update checks for add-ons via 'auto' variable.

… shows a message. re nvaccess#3208.

First of a series of foundations for add-on update facility: add a 'Check for Add-on Update' (shortcut: U) that'll let users update installed add-ons. For now, the button is non-functional - shows a message box until the client is working.

…ns manager progress dialog changes. re nvaccess#3208.

Add-on handler: add a new function (checkForAddonUpdates) that'll allow NvDA to check for add-on updates. This is to be used from add-ons manager (manual) or when NVDA starts (automatic). The goal of this function is to gather add-on listings, connect online to retrieve add-on update information, and return this info in a format that a new add-on update result dialog will use to display and download add-on bundles. The add-on update check should not run if NVDA itself is being updated (NvDA Core takes precedence).
In add-ons manager, the progress bar dialog used for add-on installation is now an attribute of the dialog itself, as it is now used for update status message as well. Also, update check button briefly displays progress dialog and returns to add-ons manager. Eventually a new add-on update result dialog will be added that'll display add-on update info returned by addonHandler.checkForAddonUpdates and download new bundles.

…on check emulation in addonHandler.checkForAddonUpdates function. re nvaccess#3208.

A prototype of add-on update check results dialog has been implemented:
* When 'update add-ons' button is pressed, a background thread will call addonHandler.checkForAddonUpdates. This function will emulate a typical add-on update check routine by sleeping for three seconds, then populating the results dictionary with records of installed add-ons, with add-on names (identifiers) as keys and containing summary and version information.
* Once update info is retrieved, the update progress bar stops, and a results dialog will be shown. While checking for updates, Add-ons Manager window will be hidden until a suitable way of showing add-on update check progress and results with Add-ons Manager window disabled is found.
* The AddonUpdatesDialog (the results dialog class) borrows heavily from NVDA Core update results dialog, displaying a list of add-ons with updates (at least emulated) or a message if update info is filled in or not, respectively.
* For now, when 'update' button is pressed from results dialog, it'll do nothing. Eventually the update button will use a refactored file downloader to download and install updates, using the file path and hash that'll be supplied by the update info dictionary.

…. re nvaccess#3208.

Similar to add-on instalaltion routines but with a difference: no prompts will be shown when updating add-ons unless serious errors occur. The new updateAddons function takes a map of new add-ons to be installed, which is a map with add-on identifiers (names) as keys and info such as path as subkeys. This function will be called when user tells NVDA to update add-ons from update results dialog.

… involves sending and receiving data in JSON format. re nvaccess#3208.

Javascript Object Notation (JSON) is a handy way to serialize and deserialize data across various systems, including sending data over a network. It can be used to send an receive various data, such as nested dictionaries, lists and so on.
In case of add-on update checker, JSON wil be employed to store add-on update information from a local NVDA installation, as well as to parse what the update server says about a possible update. A blueprint (pseudo-code) has been provided to spell out what the add-on update checker should do to accomplish its task.

…e currently installed version. re nvaccess#3208.

…s will be fetched from info url value. re nvaccess#3208.

An add-on downloader, based on updateCheck's downloader has been implemented. The only differences are title and content of the progress dialogs, destination path name and extension, and what happens once download completes (installs add-ons).
In terms of update URL's, the same approach as in NVDA Core: url list will be stored in the update info dictionary.
The only showstopper is the problem where progress dialogs for add-on downloads won't go away if multiple add-ons are being downloaded and if at least one of them has an installation UI. Once this is fixed, the manual add-on update check is considered complete (the remaining item for the client is automatic update checks, and the rest will be server's job).

…oblem, update results diallg will now handle the case of no add-on updates. re nvaccess#3208.

Somehow, either because of lack of proficiency in GUI programming (from me) or what not, when add-on update results are displayed, add-ons manager is not focused once that window is closed. This is more so after multiple add-ons are updated at the same time.
Also, update results dialog will present a message (not a list of add-ons) when no add-on updates are available, as well as laying the foundation for automatic update checks for add-ons via 'auto' variable.

…l/nvda into i3208-updateAddonsClient

…me. re nvaccess#3208.

Noted by Jamie Teh (NV Access) and Leonard from Netherlands: generators are great for doing one thing at a time. For this task, an updateAddonsGenerator will be used to update (download and install) add-ons one at a time. The generator will receive a list of add-ons to be updated, the add-on info for the to be updated add-on will be gather via list.pop, then add-on downloader and instlaler will be told to update add-ons via two kwargs: auto (automatic updates) and and list of add-ons to be updated.

This means:
* While add-ons are being updated, add-ons manager will be destroyed.
* Add-ons will be updated one at a time.
* Success/error methods in add-on downloader will call the generator defined above.

nvaccess#3208.

If for some reason an add-on fails to update, don't just quit right away - allow other add-ons to be updated. This is done by separating the generator caller to a separate function.

…updates at startup. re nvaccess#3208.

A new checkbox has been added to General Settings to check for add-on updates at startup. The infrastructure will be next.

…cks at startup. re nvaccess#3208.

At the end of auto update init code (updateCheck), added a check to allow add-on update check to proceed if NVDA Core isn't ready to be updated. Due to the fact that addonHandler.checkForAddonUpdate blocks, several functions were added to coordinate automatic add-on update checks. Lastly, once add-ons are updated via automatic means, add-ons manager will present the usual add-on change notification.

…3208

…s. re nvaccess#3208

…d of http. re nvaccess#7016

# Conflicts:
#	source/gui/addonGui.py

# Conflicts:
#	source/addonHandler.py
#	user_docs/en/userGuide.t2t

# Conflicts:
#	source/config/configSpec.py
#	source/gui/settingsDialogs.py
#	source/updateCheck.py
#	user_docs/en/userGuide.t2t

# Conflicts:
#	user_docs/en/userGuide.t2t

…ings and others in General settings panel. Re nvaccess#3208.

Instead of being destroyed (which then causes wxPython 4 to raise reference error), add-ons manager will be hidden while add-on update is in progress.

…etical order.

When installing add-ons, pop the first item so updates can proceed alphabetically.
After installing add-ons, refresh add-ons list, and then show add-ons manager window.

…r some reason. Re nvaccess#3208.

In case add-on update check (particularly automatic checks) fails, set info to None.
Also, in manifest lookup, name variable will be derived via addon.name property, which simplifies the manifest info storage routinea lot.

…y. re nvaccess#3208.

By using a combination of Select and SetState functions, select the first add-on update entry if updates are available. This is the same trick used in ad-dons manager, config profiles dilaog and others for selecting the first entry.

…pdated when update dialog is shown. Re nvaccess#3208.

Add checkboxes (list control) to add-on updates dialog so users can select which add-ons should be updated. By default, checkboxes are not checked, but one can check add-ons one wishes to update.
Also, whenever checkboxes are checked, check if update button should be enabled or not based on if at least one add-on is checked for update installation (via Python's any() function).

…n. Re nvaccess#3208.

…ckboxes will be checked by default.

…ing is not supported. Re nvaccess#3208.

…p if told to do so via a callback. Re nvaccess#3208.

Possibly due to threading issue: GUI works correctly if queued from the main thread. One way to do this is via a callback that is claled by wx.CallAfter. Thus use an internal callback when NVDA needs to display add-on update results dialog at startup.

…king turned off. Re nvaccess#3208.

Add a new set in add-on state that'll record add-ons for which update checking should not be done. With this active, add-on update check function will skip add-ons listed in that set.

…various add-ons. Re nvaccess#3208.

A new button in Add-ons Manager will open a checkable list where users can turn off add-on update checks. To turn update checking off, one would check the box for the add-on in question. Once OK button is clicked, a record of checked add-ons will be saved to add-on state and will be written to disk just to make sure the record is saved in the event of disasters.

…ing in surroudning paragraphs. Re nvaccess#3208.

…nch.

…ndler state. Re nvaccess#3208

…updateAddonsClient

…ded NVDA 'update' is not required. Re nvaccess#3208.

Add a keyword in UpdateDownader class that will ask the downloader to retrieve file version information. If set to yes, file version info will be retrieved, otherwise this step will be skipped.
The only time the new keyword will be set to False is if updating add-ons, as add-on bundles do not come with file version metadata, although this might change in the future.

…vaccess#3208.

Add-ons Manger's instlal add-on function can now update add-ons, performing different steps along the way. Also, remote add-on installer will be used to perform add-on updates if the newly added fresh instlal argument is false.

Specificlaly:

* Moved add-on update steps (at least the user interface) from add-on update downloader to Add-ons Manager class, thus unifying the routines.
* A new keyword named 'freshInstall' will be used to tell Add-ons Manager if installation wil involve updating (false) or a complete instlal (true).
* Depending on value of fresh install keyword, different messages will be presented when 'instlaling' add-ons while updating.
* Remote add-on installer has gained 'freshInstall' keyword for use in add-on update only (this keyword may become private if necessary).
* During add-on updates, install confirmation message won't be shown. The only interaction will be when the new add-on release is not compatible with current version of NVDA (see issue 6275 for more information).

… Windows Store application. Re nvaccess#3208.

…branch. Re nvaccess#3208.

Specifically:
* Instead of calling remote add-on instlal handler, the new install add-on function will be called.
* The add-oin install logic is now part of the new installAddon function that has been moved to outside of add-on GUI class.
* Due to introduction of restart prompt function, add-on update generator will call the new function instead of going through add-ons manager/close event.

…r enforced. Re nvaccess#3208.

As part of revised add-on compatibility approach, file version check is no longer performed by update downloader, thus remove this flag from update downloader and subclasses.

…lient

Python 3 edits:
* No more unicode() function.
* xrane -> range

…add-on handler. Re nvaccess#3208.

Based on flake8: lint errors such as unused urllib import, long lines, and bare exception were fixed.

Lint work include removing unused queue handler import, catching unused variable in update add-on screen, spacing, line length, and reworked logic for update add-ons button.

Lint fixes include splitting function calls into multiple lines, spaces around operators, and splitting long lines."

For function complexity note in addonGui.installAddon, this is caused by installer UI. Thus find a way to separate the instlaler from the UI.
For E402 in update check, remant from nvaccess#6275, so no need to worry.

…t least one add-on is installed. Re nvaccess#3208.

Enable add-on update check settings if add-ons are installed (perviously it was showing all the time due to a logic error regarding add-on list refresh).