--fix adds redundant space into ${VARIABLE} (SpaceBeforeOpeningBrace fix rule error)

[phts]

I have a file Jenkinsfile

pipeline {
  stages {
    stage('CleanWorkspace') {
      steps {
        cleanWs()
        dir("../${JOB_NAME}@2"){
          deleteDir()
        }
      }
    }
  }
}

$ npm-groovy-lint

  6     info     The opening brace for the closure in class None is not preceded by a space or whitespace  SpaceBeforeOpeningBrace 

and after npm-groovy-lint --fix

it becomes

pipeline {
  stages {
    stage('CleanWorkspace') {
      steps {
        cleanWs()
        dir("../$ {JOB_NAME}@2"){
          deleteDir()
        }
      }
    }
  }
}

$ npm-groovy-lint --fix

npm-groovy-lint results in  linted files:
┌─────────┬───────────┬─────────────┬─────────────┬─────────────────┐
│ (index) │ Severity  │ Total found │ Total fixed │ Total remaining │
├─────────┼───────────┼─────────────┼─────────────┼─────────────────┤
│    0    │  'Error'  │      0      │      0      │        0        │
│    1    │ 'Warning' │      0      │      0      │        0        │
│    2    │  'Info'   │      1      │      1      │        0        │
└─────────┴───────────┴─────────────┴─────────────┴─────────────────┘

which obviously breaks string content.

My .groovylint.json:

{
  "extends": "recommended-jenkinsfile",
  "rules": {
    "ClassJavadoc": "off",
    "DuplicateNumberLiteral": "off",
    "DuplicateStringLiteral": "off",
    "formatting.Indentation": {
      "severity": "error",
      "spacesPerIndentLevel": 2
    }
  }
}

---

$ npm-groovy-lint --version
GroovyLint: Successfully processed CodeNarc: 
CodeNarc version 1.6.1

npm-groovy-lint version 7.4.4

Embeds:
CodeNarc version 1.6.1
- Groovy version 3.0.5 (superlite)

$ node -v
v12.13.1

[nvuillam]

That's indeed an ugly bug , thanks for reporting !

Before I provide a fix, I suggest as workaround that you use // groovylint-disable-line SpaceBeforeOpeningBrace at the end of the line :)

ex:

pipeline {
  stages {
    stage('CleanWorkspace') {
      steps {
        cleanWs()
        dir("../${JOB_NAME}@2"){ // groovylint-disable-line SpaceBeforeOpeningBrace
          deleteDir()
        }
      }
    }
  }
}