Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autofix support for UnnecessaryReturnKeyword rule #275

Closed
wants to merge 1 commit into from

Conversation

jonnybot0
Copy link

Proposed Changes

This adds support for auto-fixing the UnnecessaryReturnKeyword rule automatically. I've tested it locally in a repository that I was applying this rule to, and it seems to work as expected.

It's unclear to me if I need to do any additional work to document this or if additional tests would be appropriate. Likewise, the files in lib changed as a result of this when I ran the build. I'm not sure if I'm meant to commit those, or if they are covered by the release process.

In short, repo newbie here! Feedback welcome. :)

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this pull request should stay open, please remove the O: stale 🤖 label or comment on the pull request.

@nvuillam
Copy link
Owner

@jonnybot0 i'm sorry i critically lack of time to maintain npm-groovy-lint, and before merging other PRs we would need to succeed to upgrade to latest groovy / CodeNarc versions, but I definitely keep this PR open for the day we can merge it ! :)

@codecov
Copy link

codecov bot commented Aug 26, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (cd70bbd) 93.06% compared to head (b7fb1d8) 93.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #275      +/-   ##
==========================================
+ Coverage   93.06%   93.08%   +0.01%     
==========================================
  Files          82       83       +1     
  Lines        1991     1995       +4     
==========================================
+ Hits         1853     1857       +4     
  Misses        138      138              
Files Changed Coverage Δ
lib/groovy-lint-rules.js 95.45% <ø> (ø)
lib/rules/UnnecessaryReturnKeyword.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this pull request should stay open, please remove the O: stale 🤖 label or comment on the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants