Update CMakeLists.txt

[floroeske]

Change Gem::AtomLyIntegration_CommonFeatures.Editor.Static to Gem::CommonFeaturesAtom.Editor.Static to match latest o3de-extras o3de/o3de-extras@bbb0da7.

[jhanca-robotecai]

Thank you for your contribution, but we prefer to keep the demo in sync with official o3de releases. As indicated in the readme file, this demo is targeting main branches of both o3de and o3de-extras. This PR should be closed until the next release in February 2024.

Edit: The decision about keeping all demos in sync with main branches is justified by the fact that, currently, we do not have the resources to keep them up to date with o3de development. Apologies for the confusing branch naming, we will keep it in mind and fix it after the upcoming point release.

[floroeske]

No problem. Thanks for clearing that up.

It wasn't clear to me which branches of o3de, o3de-extras and ROSConDemo are supposed to work together. The ROSConDemo readme on the main branch states, use the development branch (https://github.com/o3de/ROSConDemo/blob/main/README.md?plain=1#L58). I guess that created a bit of confusion. So I just used development everywhere.

I'll try again with o3de (main), o3de-extras(main) and ROSConDemo(development).

[jhanca-robotecai]

Thank you for pointing that out, it is a mistake on our side. Please use the development branch of this demo, the main branch is one year old and, most probably, will not work correctly. I will fix this after o3de point release (next week).

[jhanca-robotecai]

One more comment: it should be possible to run this demo from the docker files. Those were checked recently.