Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROS 2 Gem Support for Iron Irwini #330

Closed
5 tasks done
adamdbrw opened this issue May 15, 2023 · 5 comments
Closed
5 tasks done

ROS 2 Gem Support for Iron Irwini #330

adamdbrw opened this issue May 15, 2023 · 5 comments
Labels
feature/robotics This item is related to robotics. kind/feature Categorizes issue or PR as related to a new feature. priority/critical Critical priority. Must be actively worked on as someone's top priority right now. sig/simulation Categorizes an issue or PR as relevant to SIG Simulation triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@adamdbrw
Copy link
Contributor

adamdbrw commented May 15, 2023

Since a new ROS distro is about to be released (next week), we would like the Gem to stay modern and enable users to work with the newest distribution. This should be quite easy since this distro targets the same Ubuntu version.

  • Review change log (Iron on top of Humble) to analyze impactful changes. Consider the Gem, Templates and Demos.
  • Complete a fresh build with Iron sourced. Go through Project Setup as in the Interactivity / Robotics O3DE documentation.
  • Also test ROSCon Demo (go through the scenario as described in the demo project README).
  • Cast a PR to o3de.org documentation which adds support to Iron.
  • Cast a PR to ROSCon Demo to include Iron as an option. Also for the docker script.
@adamdbrw adamdbrw added the feature/robotics This item is related to robotics. label May 15, 2023
@byrcolin byrcolin added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. kind/feature Categorizes issue or PR as related to a new feature. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/simulation Categorizes an issue or PR as relevant to SIG Simulation labels May 16, 2023
@michalpelka
Copy link
Contributor

I reviewed change-log, and build the project from the source.

@lgleim lgleim added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/critical Critical priority. Must be actively worked on as someone's top priority right now. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 25, 2023
@arturkamieniecki
Copy link
Contributor

arturkamieniecki commented May 29, 2023

ROSCon Demo works with ROS2 Iron. Only the apple gathering cannot be checked in the main level due to the changes made in ROS 2 Gem, which are being implemented into ROSCon Demo in o3de/ROSConDemo#240. Using this PR, apple gathering can be checked in the playground level.

@arturkamieniecki
Copy link
Contributor

I've created a PR to the o3de.org documentation adding support for Iron. o3de/o3de.org#2421

@arturkamieniecki
Copy link
Contributor

I've created a PR to the ROSCon Demo repository, modifying README.md files to include support for ROS 2 Iron (o3de/ROSConDemo#248). At the moment of writing, there isn't an available docker image for ROS 2 Iron, so I haven't modified the docker script.

@jhanca-robotecai
Copy link
Contributor

At the moment of writing, there isn't an available docker image for ROS 2 Iron, so I haven't modified the docker script.

ROS 2 Iron docker image exists now and ROSConDemo works correctly in such setup, the readme and Dockerfile in ROSConDemo are updated in o3de/ROSConDemo#252

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/robotics This item is related to robotics. kind/feature Categorizes issue or PR as related to a new feature. priority/critical Critical priority. Must be actively worked on as someone's top priority right now. sig/simulation Categorizes an issue or PR as relevant to SIG Simulation triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

6 participants