Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify docs to include ROS 2 Iron #2421

Merged
merged 1 commit into from
May 31, 2023
Merged

Modify docs to include ROS 2 Iron #2421

merged 1 commit into from
May 31, 2023

Conversation

arturkamieniecki
Copy link
Contributor

Change summary

I've modified all ROS 2 documentation links to forward the user to the ROS 2 Iron documentation instead of ROS 2 Humble, reflecting the ROS 2 Gem support for ROS 2 Iron, and added information that the ROS 2 Gem supports ROS 2 Iron.

Submission Checklist:

  • Descriptive active voice - Do descriptive sentences have a clear subject and action verb?
  • Answer the question at hand - Does the documentation answer a what, why, how, or where type of question?
  • Consistency - Does the content consistently follow the Style Guide?
  • Help the user - Does the documentation show the user something meaningful?

@arturkamieniecki arturkamieniecki requested a review from a team as a code owner May 29, 2023 11:13
@arturkamieniecki arturkamieniecki mentioned this pull request May 29, 2023
Closed
5 tasks
@arturkamieniecki arturkamieniecki changed the base branch from development to main May 29, 2023 11:22
@arturkamieniecki
Modify docs to include ROS 2 Iron
d5a45df 
Signed-off-by: Artur Kamieniecki <artur.kamieniecki@robotec.ai>
@chanmosq
Copy link
Contributor

Checked that all links work. Thanks!

@chanmosq chanmosq merged commit 80dce3d into o3de:main May 31, 2023
arturkamieniecki added a commit to arturkamieniecki/o3de.org that referenced this pull request Jun 15, 2023
@arturkamieniecki
Revert "Modify docs to include ROS 2 Iron (o3de#2421)"
ee52d27 
This reverts commit 80dce3d.
@arturkamieniecki arturkamieniecki mentioned this pull request Jun 15, 2023
Merged
arturkamieniecki added a commit to arturkamieniecki/o3de.org that referenced this pull request Jun 15, 2023
@arturkamieniecki
Revert "Modify docs to include ROS 2 Iron (o3de#2421)"
564196a 
This reverts commit 80dce3d.

Signed-off-by: Artur Kamieniecki <artur.kamieniecki@robotec.ai>
adamdbrw pushed a commit that referenced this pull request Jul 10, 2023
@arturkamieniecki
Revert "Modify docs to include ROS 2 Iron" (#2433)
4594edf 
Revert "Modify docs to include ROS 2 Iron (#2421)"

This reverts commit 80dce3d.

Signed-off-by: Artur Kamieniecki <artur.kamieniecki@robotec.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chanmosq chanmosq chanmosq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arturkamieniecki @chanmosq