Support for PID and Proximity sensor buses #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
michalpelka
approved these changes
Jul 10, 2023
michalpelka
added
feature/robotics
adamdbrw
reviewed
Jul 11, 2023
Gems/ROS2/Code/Include/ROS2/ProximitySensor/ProximitySensorNotificationBus.h
Outdated
Show resolved
Hide resolved
Gems/ROS2/Code/Include/ROS2/ProximitySensor/ProximitySensorNotificationBus.h
Outdated
Show resolved
Hide resolved
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
adamdbrw
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds notification bus to
ROS2ProximitySensor(alongside with ScriptCanvas support) and adds ScriptCanvas support toPidMotorControllerComponent.Thanks to that it is possible to use a simple script:
in order to create a more advanced conveyor bus handling (note: the conveyor bus PR is an ongoing work):
20230707_conveyor_scripts_short.webm