Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finger Gripper #398

Merged
merged 8 commits into from
Jul 28, 2023
Merged

Finger Gripper #398

merged 8 commits into from
Jul 28, 2023

Conversation

Antoni-Robotec
Copy link
Contributor

@Antoni-Robotec Antoni-Robotec commented Jul 11, 2023

Depends on:
Vacuum gripper with action server
#369 (merged, rebased)
Filled the published JointState message
#388 (merged, rebased)

@Antoni-Robotec Antoni-Robotec requested review from a team as code owners July 11, 2023 08:16
@Antoni-Robotec Antoni-Robotec marked this pull request as draft July 11, 2023 08:24
@Antoni-Robotec Antoni-Robotec changed the title [Draft] Finger Gripper Finger Gripper Jul 11, 2023
@adamdbrw
Copy link
Contributor

@Antoni-Robotec I just completed a review on #369 which might affect this PR, please take a look.

@michalpelka
Copy link
Contributor

Yes, please rebase when #369 was merged

@adamdbrw
Copy link
Contributor

@Antoni-Robotec we can review this one when ready and when #369 is approved

@michalpelka michalpelka self-assigned this Jul 21, 2023
@michalpelka michalpelka added the feature/robotics This item is related to robotics. label Jul 21, 2023
@Antoni-Robotec Antoni-Robotec marked this pull request as ready for review July 21, 2023 12:39
Copy link
Contributor

@michalpelka michalpelka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@adamdbrw adamdbrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Some comments and suggestions left.

Antoni-Robotec and others added 7 commits July 27, 2023 15:41
Co-authored by: Antoni Puch <antoni.puch@robotec.ai>
Signed-off-by: Michał Pełka <michal.pelka@robotec.ai>
Signed-off-by: Antoni Puch <antoni.puch@robotec.ai>
… variables

Signed-off-by: Antoni Puch <antoni.puch@robotec.ai>
Signed-off-by: Michał Pełka <michal.pelka@robotec.ai>
Signed-off-by: Antoni Puch <antoni.puch@robotec.ai>
Co-authored-by: Adam Dąbrowski <adam.dabrowski@robotec.ai>
Signed-off-by: Antoni-Robotec <138497503+Antoni-Robotec@users.noreply.github.com>
Signed-off-by: Antoni Puch <antoni.puch@robotec.ai>
Co-authored-by: Adam Dąbrowski <adam.dabrowski@robotec.ai>
Signed-off-by: Antoni-Robotec <138497503+Antoni-Robotec@users.noreply.github.com>
Signed-off-by: Antoni Puch <antoni.puch@robotec.ai>
Signed-off-by: Antoni Puch <antoni.puch@robotec.ai>
Signed-off-by: Antoni Puch <antoni.puch@robotec.ai>
Signed-off-by: Adam Dąbrowski <adam.dabrowski@robotec.ai>
@michalpelka michalpelka merged commit 3dd1e02 into o3de:development Jul 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/robotics This item is related to robotics.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants