-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finger Gripper #398
Finger Gripper #398
Conversation
@Antoni-Robotec I just completed a review on #369 which might affect this PR, please take a look. |
Yes, please rebase when #369 was merged |
@Antoni-Robotec we can review this one when ready and when #369 is approved |
c6349e2
to
3f031bc
Compare
dbe9217
to
ca4c8e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Some comments and suggestions left.
e6d5d7e
to
2930e51
Compare
Co-authored by: Antoni Puch <antoni.puch@robotec.ai> Signed-off-by: Michał Pełka <michal.pelka@robotec.ai> Signed-off-by: Antoni Puch <antoni.puch@robotec.ai>
… variables Signed-off-by: Antoni Puch <antoni.puch@robotec.ai>
Signed-off-by: Michał Pełka <michal.pelka@robotec.ai> Signed-off-by: Antoni Puch <antoni.puch@robotec.ai>
Co-authored-by: Adam Dąbrowski <adam.dabrowski@robotec.ai> Signed-off-by: Antoni-Robotec <138497503+Antoni-Robotec@users.noreply.github.com> Signed-off-by: Antoni Puch <antoni.puch@robotec.ai>
Co-authored-by: Adam Dąbrowski <adam.dabrowski@robotec.ai> Signed-off-by: Antoni-Robotec <138497503+Antoni-Robotec@users.noreply.github.com> Signed-off-by: Antoni Puch <antoni.puch@robotec.ai>
Signed-off-by: Antoni Puch <antoni.puch@robotec.ai>
Signed-off-by: Antoni Puch <antoni.puch@robotec.ai>
2930e51
to
b0d26cb
Compare
Signed-off-by: Adam Dąbrowski <adam.dabrowski@robotec.ai>
Depends on:
Vacuum gripper with action server
#369 (merged, rebased)
Filled the published JointState message
#388 (merged, rebased)