ConveyorBeltComponent: fix for negative value of speed #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Michał Pełka <michal.pelka@robotec.ai> Signed-off-by: Paweł Budziszewski <pawel.budziszewski@robotec.ai>
adamdbrw
approved these changes
Sep 7, 2023
michalpelka
approved these changes
Sep 7, 2023
michalpelka
added a commit
to RobotecAI/o3de-extras
that referenced
this pull request
Sep 25, 2023
Signed-off-by: Paweł Budziszewski <pawel.budziszewski@robotec.ai> Co-authored-by: Michał Pełka <michal.pelka@robotec.ai>
michalpelka
added a commit
to RobotecAI/o3de-extras
that referenced
this pull request
Sep 25, 2023
Signed-off-by: Paweł Budziszewski <pawel.budziszewski@robotec.ai> Co-authored-by: Michał Pełka <michal.pelka@robotec.ai> Signed-off-by: Michał Pełka <michal.pelka@robotec.ai>
michalpelka
added a commit
to RobotecAI/o3de-extras
that referenced
this pull request
Oct 2, 2023
Signed-off-by: Paweł Budziszewski <pawel.budziszewski@robotec.ai> Co-authored-by: Michał Pełka <michal.pelka@robotec.ai> Signed-off-by: Michał Pełka <michal.pelka@robotec.ai>
michalpelka
added a commit
that referenced
this pull request
Oct 3, 2023
Signed-off-by: Paweł Budziszewski <pawel.budziszewski@robotec.ai> Co-authored-by: Michał Pełka <michal.pelka@robotec.ai> Signed-off-by: Michał Pełka <michal.pelka@robotec.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the speed of the ConveyorBeltComponent was set to a negative value, belt segments were massively spawned in an infinite loop, causing a crash eventually. The belt was not moving correctly.
Setting a negative speed is the simplest way of changing movement direction.
Moved from RobotecAI#35