Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update prefab override documentation #2479

Merged

Conversation

alexmontAmazon
Copy link
Contributor

@alexmontAmazon alexmontAmazon commented Oct 4, 2023

Change summary

Update the prefab override documentation to reflect new variable names and the switch from registry to cvar settings.

Submission Checklist:

  • Descriptive active voice - Do descriptive sentences have a clear subject and action verb?
  • Answer the question at hand - Does the documentation answer a what, why, how, or where type of question?
  • Consistency - Does the content consistently follow the Style Guide?
  • Help the user - Does the documentation show the user something meaningful?

Signed-off-by: Alex Montgomery <alexmont@amazon.com>
Copy link
Contributor

@cgalvan cgalvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth combining these into one section, because they aren't super useful independently (e.g. if you enable in the outliner but not in the inspector, then your changes won't actually trigger to be overrides, and if you only enable in inspector but not outliner, then you won't be able to even select entities in the outliner that overrides would apply to).

@alexmontAmazon
Copy link
Contributor Author

It might be worth combining these into one section, because they aren't super useful independently (e.g. if you enable in the outliner but not in the inspector, then your changes won't actually trigger to be overrides, and if you only enable in inspector but not outliner, then you won't be able to even select entities in the outliner that overrides would apply to).

That's a good point, but this is at least a step forward. I'm going to merge this and then see about more drastic doc changes...

@alexmontAmazon alexmontAmazon merged commit 8bd2b2e into o3de:stabilization/2310 Oct 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants