Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HumanWorker, OTTO Robots, RGL and UR Robots robotic Gems #2517

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

jhanca-robotecai
Copy link
Contributor

@jhanca-robotecai jhanca-robotecai commented Dec 12, 2023

Change summary

Multiple robotic Gems, external to o3de repositories, are missing from the documentation. I believe adding information about such Gems would narrow the learning curve of O3DE robotics.

The information about the following Gems was added:

Note, that all Gems listed earlier are open source. Three of them were used in ROSCon2023Demo project, which received a significant audience during the conference and via online channels.

I also found several Gems in o3de-extras repository with missing documentation. These will be added in the following PR or the following commits.

Draft: the gems described in this PR will be officially released after o3de 2310.1 release.

Submission Checklist:

  • Descriptive active voice - Do descriptive sentences have a clear subject and action verb?
  • Answer the question at hand - Does the documentation answer a what, why, how, or where type of question?
  • Consistency - Does the content consistently follow the Style Guide?
  • Help the user - Does the documentation show the user something meaningful?

Copy link
Contributor

@adamdbrw adamdbrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you modify it to active tone - as in, taking user perspective, what can be done with the Gem and how?
Adding pictures and feature/component list with short description would be useful, regardless of their presence in linked repo.

Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
@jhanca-robotecai jhanca-robotecai marked this pull request as ready for review December 19, 2023 10:34
@jhanca-robotecai jhanca-robotecai requested a review from a team as a code owner December 19, 2023 10:34
@adamdbrw
Copy link
Contributor

I think this PR also includes (and very much expands on) the older one: #2504, which can be closed.

@adamdbrw adamdbrw merged commit 39c1163 into development Dec 21, 2023
5 checks passed
@adamdbrw adamdbrw deleted the jhanca-robotecai/add_gems branch December 21, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants