Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CIs: test with el9stream #334

Merged
merged 2 commits into from
Oct 4, 2022
Merged

CIs: test with el9stream #334

merged 2 commits into from
Oct 4, 2022

Conversation

aesteve-rh
Copy link
Member

Add centos-stream-9 Dockerfile to the
docker folder so that it can be built,
and used in the pipelines.

Signed-off-by: Albert Esteve aesteve@redhat.com

@aesteve-rh
Copy link
Member Author

An (almost) passing run in my fork: https://github.com/aesteve-rh/vdsm/actions/runs/3172453877

Also, we would need to update the expected CI jobs.

@mz-pdm
Copy link
Member

mz-pdm commented Oct 3, 2022

Looks good to me. What's the permission problem when pulling the containers?

@aesteve-rh
Copy link
Member Author

aesteve-rh commented Oct 3, 2022 •
edited
Loading

I had introduced an error when reverting the name of the user for the container repositories to oVirt, since I was using my own user for testing. Fixed in the last push.

What's the permission problem when pulling the containers? In its current status, I have not pushed the centos-9 containers to the ovirt quay.io repository, so they will fail. Which cancels centos-8 jobs, not sure why :/

@nirs
Copy link
Member

nirs commented Oct 3, 2022

In its current status, I have not pushed the centos-9 containers to the ovirt quay.io repository, so they will fail. Which cancels centos-8 jobs, not sure why :/

If the container works, please push it to quay so we can make progress with this pr.

nirs
nirs reviewed Oct 3, 2022
View reviewed changes
.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
@aesteve-rh aesteve-rh force-pushed the aesteve/centos9-container branch 2 times, most recently from e02d6c3 to af5d8cf Compare October 4, 2022 09:30
tinez
tinez reviewed Oct 4, 2022
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@aesteve-rh
docker: add centos-9 test container
fda1a47 
Add centos-stream-9 Dockerfile to the
docker folder so that it can be build and
pushed, and later used in the pipelines.

Signed-off-by: Albert Esteve <aesteve@redhat.com>
@aesteve-rh
ci.yml: add centos-9 to container matrix
ab37085 
Create distro matrix for testing different containers
in the pipelines. Add centos-9 to the already
existing centos-8 distro to the distro matrix.

Fixes: oVirt#333
Signed-off-by: Albert Esteve <aesteve@redhat.com>
@aesteve-rh aesteve-rh requested review from nirs and tinez October 4, 2022 11:47
@aesteve-rh aesteve-rh self-assigned this Oct 4, 2022
@mz-pdm mz-pdm merged commit a7fe08b into oVirt:master Oct 4, 2022
@aesteve-rh aesteve-rh deleted the aesteve/centos9-container branch October 4, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tinez tinez tinez approved these changes

@almusil almusil Awaiting requested review from almusil almusil is a code owner

@mz-pdm mz-pdm Awaiting requested review from mz-pdm mz-pdm is a code owner

@nirs nirs Awaiting requested review from nirs

Assignees

@aesteve-rh aesteve-rh

Labels
infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aesteve-rh @mz-pdm @nirs @tinez