Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reuse: Put SPDX after XML declaration #343

Merged
merged 1 commit into from
Oct 14, 2022
Merged

reuse: Put SPDX after XML declaration #343

merged 1 commit into from
Oct 14, 2022

Conversation

mz-pdm
Copy link
Member

@mz-pdm mz-pdm commented Oct 12, 2022

A valid XML should start with the declaration and only then comments are allowed.

@mz-pdm
reuse: Put SPDX after XML declaration
70d23bb 
A valid XML should start with the declaration and only then comments
are allowed.
@mz-pdm mz-pdm requested a review from tinez as a code owner October 12, 2022 16:09
mwperina
mwperina approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@mz-pdm mz-pdm merged commit 00d2f80 into oVirt:master Oct 14, 2022
@mz-pdm mz-pdm deleted the spdx-xml# branch October 14, 2022 14:20
@aesteve-rh
Copy link
Member

Thanks for the fix! I will make an issue in the reuse forums with this one, as the reuse tool autofills it wrongly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwperina mwperina mwperina approved these changes

@tinez tinez Awaiting requested review from tinez tinez is a code owner

@aesteve-rh aesteve-rh Awaiting requested review from aesteve-rh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mz-pdm @aesteve-rh @mwperina