Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

volume: Extend raw sparse #390

Merged
merged 2 commits into from
May 30, 2023

Conversation

aesteve-rh
Copy link
Member

@aesteve-rh aesteve-rh commented May 29, 2023

Consider format also on the skip condition
for extending volumes. Only COW sparse volumes
shall be skipped.

Fixes: c9d6da4
Bug-Url: https://bugzilla.redhat.com/2210036
Signed-off-by: Albert Esteve aesteve@redhat.com

Add test to verify that raw sparse volumes in
file storage are extended with the vol.extendSize()
logic.

Currently, test is expected to fail as all sparse
volumes are skipped in the extendSize() call.

Signed-off-by: Albert Esteve <aesteve@redhat.com>
@aesteve-rh aesteve-rh added bug Issue is a bug or fix for a bug storage labels May 29, 2023
@aesteve-rh aesteve-rh requested review from nirs, mz-pdm and ahadas May 29, 2023 14:02
@aesteve-rh aesteve-rh self-assigned this May 29, 2023
@aesteve-rh
Copy link
Member Author

/ost

Copy link
Member

@mz-pdm mz-pdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT

Copy link
Member

@nirs nirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"shall be extended" should be "shall be skipped"

Consider format also on the skip condition
for extending volumes. Only COW sparse volumes
shall be skipped.

Fixes: c9d6da4
Bug-Url: https://bugzilla.redhat.com/2210036
Signed-off-by: Albert Esteve <aesteve@redhat.com>
@aesteve-rh aesteve-rh merged commit 07d3089 into oVirt:master May 30, 2023
@aesteve-rh aesteve-rh deleted the aesteve/extend-raw-sparse branch May 30, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is a bug or fix for a bug storage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants