Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go: Various requested gRPC API additions. #2750

Merged
merged 2 commits into from
Mar 3, 2020

Conversation

Yawning
Copy link
Contributor

@Yawning Yawning commented Mar 2, 2020

Notes:

  • The new Delegations call mimics the existing DebondingDelegations call, and requires specifying the delegator ID.

@Yawning Yawning added p:3 Priority: nice to have c:apps Category: application support golang c:staking Category: staking labels Mar 2, 2020
@Yawning Yawning self-assigned this Mar 2, 2020
@Yawning Yawning force-pushed the yawning/feature/grpc-api-additions branch from ec9faa9 to c641239 Compare March 2, 2020 15:33
@Yawning Yawning requested a review from kostko March 2, 2020 15:37
@codecov
Copy link

codecov bot commented Mar 2, 2020

Codecov Report

Merging #2750 into master will decrease coverage by 0.01%.
The diff coverage is 26.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2750      +/-   ##
==========================================
- Coverage   62.77%   62.75%   -0.02%     
==========================================
  Files         383      383              
  Lines       36097    36159      +62     
==========================================
+ Hits        22659    22691      +32     
- Misses      10594    10597       +3     
- Partials     2844     2871      +27
Impacted Files Coverage Δ
go/scheduler/api/api.go 71.15% <ø> (ø) ⬆️
go/staking/api/api.go 71.42% <ø> (ø) ⬆️
go/scheduler/tests/tester.go 94.24% <ø> (ø) ⬆️
...o/consensus/tendermint/apps/staking/state/state.go 62.76% <0%> (-2.66%) ⬇️
go/consensus/tendermint/staking/staking.go 68% <0%> (-2.35%) ⬇️
go/staking/api/grpc.go 53.33% <0%> (-3.81%) ⬇️
go/consensus/tendermint/apps/staking/query.go 64.86% <0%> (-3.71%) ⬇️
go/consensus/tendermint/apps/registry/query.go 76.36% <100%> (+3.44%) ⬆️
go/consensus/tendermint/apps/scheduler/query.go 63.63% <43.75%> (-13.04%) ⬇️
go/common/grpc/proxy/proxy.go 58.87% <0%> (-5.61%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f331a87...4ef4106. Read the comment docs.

This adds a Delegations call in the spirt of DebondingDelegations that
returns a map of delegations for a given delegator.
@Yawning Yawning force-pushed the yawning/feature/grpc-api-additions branch 2 times, most recently from ecb3e61 to d81f377 Compare March 3, 2020 12:26
The consensus ID isn't all that useful for most external callers, so
querying it should just return the validators by node ID instead.
@Yawning Yawning force-pushed the yawning/feature/grpc-api-additions branch from d81f377 to 4ef4106 Compare March 3, 2020 12:41
@Yawning Yawning marked this pull request as ready for review March 3, 2020 13:06
Copy link
Contributor

@peterjgilbert peterjgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yawning Yawning merged commit 0dee03d into master Mar 3, 2020
@Yawning Yawning deleted the yawning/feature/grpc-api-additions branch March 3, 2020 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:apps Category: application support c:staking Category: staking golang p:3 Priority: nice to have
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants