-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify runtime descriptors to support ADR 0004 #3548
Conversation
f49b271
to
6a08f96
Compare
Codecov Report
@@ Coverage Diff @@
## master #3548 +/- ##
==========================================
+ Coverage 67.23% 67.31% +0.08%
==========================================
Files 390 390
Lines 36540 36667 +127
==========================================
+ Hits 24567 24683 +116
- Misses 8524 8529 +5
- Partials 3449 3455 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to update the documentation and add tests for the new features (whitelist changes, minimum pool size, submitting register runtime txes for consensus/runtime governance types).
4dc4c56
to
1b50bbd
Compare
Yes, this should be a separate PR. |
3a97740
to
f3cb039
Compare
102c622
to
3f6d9ea
Compare
// XXX: The "0" case is only for backward compatibility, so that the old | ||
// genesis file loads -- remove this once mainnet is upgraded! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it be better if we handled this in fixgenesis?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, because there are too many structures to duplicate and there's more chance of something going wrong with the conversion (and since this is in staking code it's better to be more careful). A two-line fix like this is cleaner, IMO :)
I'll file an issue later, so we don't forget to remove this once the upgrade is complete.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filed as #3627 :)
aa760c6
to
cc754fe
Compare
Thanks for the comments! This is now ready for re-review. |
539ef3f
to
010f479
Compare
010f479
to
c6c36fd
Compare
3f71537
to
d51975a
Compare
d51975a
to
ca84d78
Compare
Thanks! |
Closes #3450.
TODO:
SignedRuntime
entirely.oasis-node debug fix-genesis
command does the right thing.go/consensus/tendermint/apps/registry/transactions.go
.enable_runtime_governance_models
consensus parameter & tests for it.In a separate PR:
update_runtime
runtime message support & e2e tests.