go/control/GetStatus: include the latest epoch #3753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrus
requested review from
kostko,
peterjgilbert,
pro-wh and
Yawning
as code owners
ptrus
force-pushed
the
ptrus/status/epoch
branch
from
31617dd
to
cc40820
Compare
kostko
reviewed
Mar 4, 2021
go/consensus/tendermint/full/full.go
Outdated
| // Latest block epoch. | ||
| epoch, err := t.beacon.GetEpoch(ctx, status.LatestHeight) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to fetch epoch: %w", err) |
There was a problem hiding this comment.
Could this fail when there's no committed blocks? Maybe it should only query the epoch in case if successfully fetches the block above.
There was a problem hiding this comment.
Nice, this was actually caught by the early query E2E test :-)
There was a problem hiding this comment.
😁 oh yeah i thought we'll fail early above if there's no committed block, missed the exception.
ptrus
force-pushed
the
ptrus/status/epoch
branch
from
cc40820
to
a48fd73
Compare
kostko
approved these changes
Mar 4, 2021
go/consensus/tendermint/full/full.go
Outdated
| @@ -788,6 +788,11 @@ func (t *fullService) GetStatus(ctx context.Context) (*consensusAPI.Status, erro | |||
| status.LatestHash = latestBlk.Hash | |||
| status.LatestTime = latestBlk.Time | |||
| status.LatestStateRoot = latestBlk.StateRoot | |||
| epoch, err := t.beacon.GetEpoch(ctx, status.LatestHeight) | |||
ptrus
force-pushed
the
ptrus/status/epoch
branch
from
a48fd73
to
351fd93
Compare
ptrus
force-pushed
the
ptrus/status/epoch
branch
from
351fd93
to
9fd48ed
Compare
ptrus
force-pushed
the
ptrus/status/epoch
branch
from
9fd48ed
to
74e3019
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3743