Fix handling of detached bundles #5785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kostko
commented
Jul 23, 2024
kostko
commented
- go/runtime: Automatically enable all configured detached components
- go/runtime/bundle: Use manifest hash at bundle load time
✅ Deploy Preview for oasisprotocol-oasis-core canceled.
|
Since they are explicitly configured there should be no need to enable them twice. This just defaults detached components to be enabled and one needs to explicitly disable them.
kostko
force-pushed
the
kostko/feature/detached-comps-autoenable
branch
from
b98e8ef
to
bfdf208
Compare
kostko
requested review from
peterjgilbert,
pro-wh,
ptrus and
peternose
as code owners
peternose
approved these changes
Jul 23, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5785 +/- ##
==========================================
+ Coverage 64.82% 65.62% +0.79%
==========================================
Files 621 621
Lines 63393 63399 +6
==========================================
+ Hits 41096 41607 +511
+ Misses 17421 16969 -452
+ Partials 4876 4823 -53 ☔ View full report in Codecov by Sentry. |
peternose
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.