Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/runtime: Support bundle components without ELF binary #5838

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

kostko
Copy link
Member

@kostko kostko commented Aug 28, 2024

Fixes #5780

Copy link

netlify bot commented Aug 28, 2024

Deploy Preview for oasisprotocol-oasis-core canceled.

Name Link
🔨 Latest commit 7048cbb
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-oasis-core/deploys/66d85f1de69ac10008281e3b

@kostko kostko force-pushed the kostko/feature/bundle-noelf branch from ff20ce0 to af9deb9 Compare August 28, 2024 11:40
@kostko kostko marked this pull request as ready for review August 28, 2024 11:49
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 53.84615% with 18 lines in your changes missing coverage. Please review.

Project coverage is 65.01%. Comparing base (5d54347) to head (af9deb9).
Report is 1 commits behind head on master.

Files Patch % Lines
go/runtime/registry/config.go 54.83% 11 Missing and 3 partials ⚠️
go/runtime/bundle/manifest.go 50.00% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5838      +/-   ##
==========================================
- Coverage   65.49%   65.01%   -0.48%     
==========================================
  Files         621      621              
  Lines       63439    63451      +12     
==========================================
- Hits        41548    41255     -293     
- Misses      17041    17346     +305     
  Partials     4850     4850              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

go/runtime/registry/config.go Show resolved Hide resolved
@kostko kostko disabled auto-merge September 4, 2024 13:30
@kostko kostko merged commit bfa8e50 into master Sep 4, 2024
5 checks passed
@kostko kostko deleted the kostko/feature/bundle-noelf branch September 4, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support bundle components without ELF binary
2 participants