Add signed data/leash/signature to eth_call data #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oasisprotocol-sapphire-paratime ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
CedarMist
requested changes
Sep 18, 2024
clients/py/sapphirepy/sapphire.py
Outdated
| "data": params[0].get('data'), | ||
| "leash": | ||
| { | ||
| "nonce": web3.eth.get_transaction_count(params[0].get('from')), |
There was a problem hiding this comment.
Extract block and nonce into variable, to prevent multiple RPC requests for same data.
clients/py/sapphirepy/sapphire.py
Outdated
| raise RuntimeError('Could not retrieve callDataPublicKey!') | ||
| do_fetch = False | ||
|
|
||
| c = _encrypt_tx_params(pk, params, w3, account) |
There was a problem hiding this comment.
This makes no distinction between transactions being submitted and eth_call . This will break transactions - need two code paths, one for transactions and one for eth_call.
| 'leash': leash, | ||
| 'signature': signed_msg['signature'], | ||
| } | ||
| params[0]['data'] = cbor2.dumps(data_pack, canonical=True) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds signed queries to sapphire-py wrapper. Based on Go client, it builds a data_pack dictionary containing the signature and eip712 message data.
Currently returns "execution_reverted" error when testing on sapphire-localnet.