Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --base-git <repo> argument #51

Closed
Tracked by #61
epage opened this issue Aug 9, 2022 · 2 comments · Fixed by #87
Closed
Tracked by #61

Add --base-git <repo> argument #51

epage opened this issue Aug 9, 2022 · 2 comments · Fixed by #87
Labels
A-cli Area: engine around the lints C-enhancement Category: raise the bar on expectations

Comments

@epage
Copy link
Collaborator

epage commented Aug 9, 2022

With --rev, --tag, --branch flags so someone can compare the API against a repo

This would be exclusive with #50
@epage
Copy link
Collaborator Author

epage commented Aug 9, 2022

When cargo loads git repos, it recursively walks the whole repo, identifying all Cargo.toml files.

This was referenced Aug 9, 2022
Closed
Open
Open
@epage epage added A-cli Area: engine around the lints C-enhancement Category: raise the bar on expectations labels Aug 9, 2022
@epage
Copy link
Collaborator Author

epage commented Aug 18, 2022

I forgot that the person is already in the repo. We don't need a --baseline-git flag, only --baseline-rev, etc

epage added a commit to epage/cargo-semver-check that referenced this issue Aug 18, 2022
@epage
feat(cli): Use a local git rev as a baseline
848b21e 
Fixes obi1kenobi#51
@epage epage mentioned this issue Aug 18, 2022
Merged
@epage epage closed this as completed in #87 Aug 18, 2022
epage added a commit that referenced this issue Aug 18, 2022
@epage
feat(cli): Use a local git rev as a baseline
6703d44 
Fixes #51
@epage epage mentioned this issue Aug 31, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-cli Area: engine around the lints C-enhancement Category: raise the bar on expectations
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cli): Use a local git rev as a baseline epage/cargo-semver-check
1 participant
@epage