Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm: implement stack #2

Open
obscuren opened this issue Jul 3, 2016 · 7 comments
Open

vm: implement stack #2

obscuren opened this issue Jul 3, 2016 · 7 comments
Labels

Comments

@obscuren
Copy link
Owner

obscuren commented Jul 3, 2016

No description provided.

@kehiy
Copy link
Contributor

kehiy commented Aug 3, 2024

@obscuren I can work on that, any details of where this stack must be used? so after implementing it I can use it where we need it and make a PR.

@obscuren
Copy link
Owner Author

obscuren commented Aug 3, 2024

This was 2016… I honestly can’t remember.

Are you using this for anything in specific? Do you require a functioning stack?

@kehiy
Copy link
Contributor

kehiy commented Aug 4, 2024

@obscuren Oh, that's logical I can understand. I'm reading the code and working on it to learn. I'm working on VMs and I'm interested in developing them. I found this to be very straightforward and nice good. I'm just trying to finish the unfinished parts.

@kehiy
Copy link
Contributor

kehiy commented Aug 4, 2024

I'll try to read the code to find out where we need a stack.

@kehiy
Copy link
Contributor

kehiy commented Aug 10, 2024

@obscuren I think this was planned for Push(s) and Pop OP codes. Am I right? If you think it's correct, let me know. So I can finish this.

Also, what is the datatype of our stack items? can it be uint256 the same as EVM?

@obscuren
Copy link
Owner Author

No, push and pop only support 32bits. See https://github.com/obscuren/tinyvm?tab=readme-ov-file#instruction-encoding

@kehiy
Copy link
Contributor

kehiy commented Aug 11, 2024

Got it. in next PR I'll add it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants