vm: implementing stack #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I checked the readme and source code and I reached that this stack issue and push/pop opcodes have these purposes:
stack issue: you created it to implement a stack to use as a call stack (based on TODOs)
push/pop op codes: They are compiling into 2 op codes such as load memory, sub and add. so they are not meant to be stack operations, also this VM was not a stack machine at all.
Overall I reached that these changes must fix the open issue.
This PR contains some linting modifications. using builder for better performance. and some small changes on readme as well.