Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed app.Start to app.Run #1

Merged
merged 1 commit into from
Oct 2, 2020
Merged

Changed app.Start to app.Run #1

merged 1 commit into from
Oct 2, 2020

Conversation

jpkrohling
Copy link
Contributor

See open-telemetry/opentelemetry-collector#1790

Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de

@jpkrohling
Changed app.Start to app.Run
d0e79b4 
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
objectiser
objectiser approved these changes Oct 2, 2020
View reviewed changes
Copy link

@objectiser objectiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this affect the existing observatorium collector-otel example?

@jpkrohling
Copy link
Contributor Author

Sort of, as soon as this is merged, new builds from that example will use this if a new binary is installed (go get/install).

@jpkrohling jpkrohling merged commit 3cd3923 into observatorium:master Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@objectiser objectiser objectiser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpkrohling @objectiser