Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix error message from newer svelte dependencies. #2119

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

claremacrae
Copy link
Collaborator

Description

Fix error message from newer svelte dependencies.

The error message was:

Error: Argument of type '{ "bind:value": string; id: string; type: string; class: string; placeholder: string; accesskey: string | null; "on:keydown": (e: KeyboardEvent) => void; "on:paste": () => void; "on:drop": () => void; }' is not assignable to parameter of type 'HTMLProps<"textarea", HTMLAttributes<any>>'.
  Object literal may only specify known properties, and '"type"' does not exist in type 'HTMLProps<"textarea", HTMLAttributes<any>>'. (ts)
                id="description"
                type="text"
                class="tasks-modal-description"

They are complaining about the 'type="text"' line.

When I delete that line and test the Create or edit task modal, the Description field still works fine.

I believe that this line was a hangover from an earlier version of this code where the Description field was a one-line field.

Motivation and Context

See the initial build failures in:

How has this been tested?

  • By building the Tasks plugin locally, having manually applied the version updates from the two PRs above
  • And then testing that editing the Description field still works.

Screenshots (if appropriate)

Types of changes

Internal changes:

  • Refactor (prefix: refactor - non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)

Checklist

Terms

The error message was:

Error: Argument of type '{ "bind:value": string; id: string; type: string; class: string; placeholder: string; accesskey: string | null; "on:keydown": (e: KeyboardEvent) => void; "on:paste": () => void; "on:drop": () => void; }' is not assignable to parameter of type 'HTMLProps<"textarea", HTMLAttributes<any>>'.
  Object literal may only specify known properties, and '"type"' does not exist in type 'HTMLProps<"textarea", HTMLAttributes<any>>'. (ts)
                id="description"
                type="text"
                class="tasks-modal-description"

They are complaining about the 'type="text"' line.

When I delete that line and test the Create or edit task modal,
the Description field still works fine.

I believe that this line was a hangover from an earlier version of this
code where the Description field was a one-line field.
@claremacrae claremacrae added the type: internal Only regards development or contributing label Jul 11, 2023
@claremacrae claremacrae merged commit 86cc9ac into main Jul 11, 2023
2 checks passed
@claremacrae claremacrae deleted the chore-fix-svelte-error branch July 11, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: internal Only regards development or contributing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant