Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translations from Crowdin #10300

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

Vainock
Copy link
Contributor

@Vainock Vainock commented Feb 27, 2024

Description

Update translations from Crowdin for the 30.1.0 release.

Motivation and Context

Crowdin's API is currently broken -> failing translation update action: https://community.crowdin.com/t/unable-to-list-blocked-users-via-api/6981/2

How Has This Been Tested?

/

Types of changes

  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@RytoEX RytoEX added this to the OBS Studio 30.1 milestone Feb 27, 2024
@RytoEX RytoEX self-assigned this Feb 27, 2024
@RytoEX RytoEX added the Enhancement Improvement to existing functionality label Feb 27, 2024
@Vainock
Copy link
Contributor Author

Vainock commented Feb 27, 2024

I might force push further translation updates over the coming days as long as this PR isn't merged.

@RytoEX
Copy link
Member

RytoEX commented Feb 27, 2024

I might force push further translation updates over the coming days as long as this PR isn't merged.

It will probably be merged within the next 12-24 hours.

Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This by itself seems fine.

I did notice that there is a newly added locale set (kaa.ini, Karakalpak / Qaraqalpaqsha), and while it is copied to the OBS Studio build, it does not show up in the UI as an option.

Looking into that, I noticed that there are currently 52 languages in UI/data/locale.ini (the file the provides the list of available languages to select in Settings), but 74 different locale files in UI/data/locale. The last update to UI/data/locale.ini was two years ago by the Translation Updater (ac8dbf6). I am happy to update this file manually, but am wondering why the Translation Updater has not updated it since then. That issue is out of scope for this PR, but I wanted to document it somewhere.

@RytoEX
Copy link
Member

RytoEX commented Feb 28, 2024

I did notice that there is a newly added locale set (kaa.ini, Karakalpak / Qaraqalpaqsha), and while it is copied to the OBS Studio build, it does not show up in the UI as an option.

Looking into that, I noticed that there are currently 52 languages in UI/data/locale.ini (the file the provides the list of available languages to select in Settings), but 74 different locale files in UI/data/locale. The last update to UI/data/locale.ini was two years ago by the Translation Updater (ac8dbf6). I am happy to update this file manually, but am wondering why the Translation Updater has not updated it since then. That issue is out of scope for this PR, but I wanted to document it somewhere.

I see now that this is based on locale translation progress, so this is probably fine. I didn't cross-check the language lists, but the check itself seems fine.
https://github.com/obsproject/obs-crowdin-sync/blob/30b5446e3b5eb19595aa68a81ddf896a857302cf/src/download.ts#L391

@RytoEX RytoEX merged commit 7ae66c7 into obsproject:master Feb 28, 2024
14 checks passed
@Vainock Vainock deleted the update-translations-30.1.0 branch March 4, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants