aja: Remove holding source settings #11191
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes
AJASource::CaptureThread
to hold the settings of the source.Waiting
Motivation and Context
The API
obs_source_update
accept nullptr for the argumentsettings
and it will just call theupdate
callback without changing the settings.The usages of
obs_source_update
seems to trigger theupdate
callback in the graphics thread.For that purpose, it is sufficient to pass nullptr as the 2nd argument.
How Has This Been Tested?
I haven't test it as I couldn't reached the branch.
Types of changes
Checklist: