Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aja: Remove holding source settings #11191

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

norihiro
Copy link
Contributor

Description

This PR removes AJASource::CaptureThread to hold the settings of the source.

Waiting

Motivation and Context

The API obs_source_update accept nullptr for the argument settings and it will just call the update callback without changing the settings.

The usages of obs_source_update seems to trigger the update callback in the graphics thread.
For that purpose, it is sufficient to pass nullptr as the 2nd argument.

How Has This Been Tested?

I haven't test it as I couldn't reached the branch.

Types of changes

  • Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

The API `obs_source_update` accept NULL for the argument `settings` and
it will just call the `update` callback without changing the settings.
@WizardCM WizardCM added the Code Cleanup Non-breaking change which makes code smaller or more readable label Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Cleanup Non-breaking change which makes code smaller or more readable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants