Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Change clip level to 0.0 dB #11230

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

cg2121
Copy link
Contributor

@cg2121 cg2121 commented Sep 1, 2024

Description

This changes the clip level of the volume meters from -0.5 dB to 0.0 dB.

Motivation and Context

I think the original intention was to tell users they had too loud of audio without actually clipping the audio. But if audio was intended to be this high of level, such as music, it would show it was clipping without it actually clipping.

Brought up by @PatTheMav off thread.

How Has This Been Tested?

Tested audio with a high dB level, but not clipping, to make sure the volume controls didn't show the clipping indicators.

Types of changes

  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@cg2121 cg2121 added Enhancement Improvement to existing functionality UI/UX Anything to do with changes or additions to UI/UX elements. labels Sep 1, 2024
@SuslikV
Copy link
Contributor

SuslikV commented Sep 2, 2024

Right now it affects only input meter (small rectangle).

@cg2121
Copy link
Contributor Author

cg2121 commented Sep 3, 2024

Fixed the code now, so the clip level affects both the input and output meters.

The clip level variable would only affect the input meters not the
output meters.
This changes the clip level of the volume meters from -0.5 dB to 0.0 dB.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvement to existing functionality UI/UX Anything to do with changes or additions to UI/UX elements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants