Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy_check CMake macro #11248

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Conversation

tytan652
Copy link
Collaborator

@tytan652 tytan652 commented Sep 6, 2024

Description

The macro was not removed in 72428cc waiting for submodules to be be updated to a commit where their legacy code path is removed.

Motivation and Context

The macro is non-functional (a stub) but was kept until submodules are updated to no longer require it.

How Has This Been Tested?

No issue configuring and building on Linux, CI will tell for other platforms

Types of changes

  • Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

The macro was not removed in 72428cc
waiting for submodules to be be updated to a commit where their legacy
code path is removed.
@tytan652 tytan652 added the Code Cleanup Non-breaking change which makes code smaller or more readable label Sep 6, 2024
@RytoEX RytoEX self-assigned this Sep 10, 2024
@RytoEX RytoEX added this to the OBS Studio 31 milestone Sep 10, 2024
Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine at a glance.

@RytoEX RytoEX merged commit 3138500 into obsproject:master Sep 11, 2024
14 checks passed
@tytan652 tytan652 deleted the drop_legacy_check branch September 11, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Cleanup Non-breaking change which makes code smaller or more readable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants