Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obs-nvenc: Support new error code for too many sessions #11259

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

derrod
Copy link
Member

@derrod derrod commented Sep 10, 2024

Description

At some point NVIDIA started using NV_ENC_ERR_INCOMPATIBLE_CLIENT_KEY instead of NV_ENC_ERR_OUT_OF_MEMORY to signal that the session limit has been exceeded.

Motivation and Context

Want to provide users with more meaningful error message.

How Has This Been Tested?

Verified this error code occurs when session limit is hit, and that the error message with this PR is accurate.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

At some point NVIDIA started using NV_ENC_ERR_INCOMPATIBLE_CLIENT_KEY
instead of NV_ENC_ERR_OUT_OF_MEMORY to signal that the session limit
has been exceeded.
@derrod derrod added the Bug Fix Non-breaking change which fixes an issue label Sep 10, 2024
Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RytoEX RytoEX merged commit 4b0777a into obsproject:master Sep 10, 2024
14 checks passed
@RytoEX RytoEX added this to the OBS Studio 31 milestone Sep 10, 2024
@derrod derrod deleted the nvenc-support-new-oos-error branch September 10, 2024 21:52
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Non-breaking change which fixes an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants