Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added BatList.frange #745

Merged
merged 1 commit into from
Apr 6, 2017
Merged

Conversation

UnixJunkie
Copy link
Member

should be quite useful to scientific programmers.
It's the second time that I identify that I need this in a project, so here it is.

@gasche
Copy link
Member

gasche commented Apr 6, 2017

What's the reason for asking To/Downto instead of inferring it from whether start <= stop or start >= stop?

@UnixJunkie
Copy link
Member Author

I tried to match the interface of BatList.range (which I added long time ago).
Also, in scientific code it doesn't hurt to be very explicit about what you are trying to do.

@gasche gasche merged commit aa1c635 into ocaml-batteries-team:master Apr 6, 2017
@gasche
Copy link
Member

gasche commented Apr 6, 2017

Oh, sure. Merged, thanks!

@gasche
Copy link
Member

gasche commented Apr 6, 2017

I added a Changes entry in 4720636.

@UnixJunkie
Copy link
Member Author

thanks for the review and the changelog update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants