BatInt.Safe_int.mul performance improvements #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fast-path was made less expensive, by getting rid of absolute value computation (which incurs branching). The downside is that the fast-path supports only non-negative integers from now on.
|
I looked at this and, while I don't understand the code very well as you do, I believe that the change is correct. Could you add a |
murmour
force-pushed
the
SafeInt.mul-tweak
branch
from
bdb9603
to
0659a90
Compare
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes the fast-path of
BatInt.Safe_int.mulless expensive, by getting rid of the absolute value computation (which incurs branching). The downside is that the fast-path supports only non-negative integers from now on.I am responsible for making the fast-path support negative numbers (#590). It made sense for a particular application of mine, but further experience showed that multiplication of positive integers is much more common in practice, in a wide variety of situations.